Re: [PATCH v1 05/25] j1939: socket: introduce local_pgn and set in bind()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
Subject: Re: [PATCH v1 05/25] j1939: socket: introduce local_pgn and set in bind()
From: Kurt Van Dijck <dev.kurt@xxxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 4 Apr 2019 19:52:39 +0200
Cc: mkl@xxxxxxxxxxxxxx, wg@xxxxxxxxxxxxxx, kernel@xxxxxxxxxxxxxx, linux-can@xxxxxxxxxxxxxxx, robin@xxxxxxxxxxx, david@xxxxxxxxxxx
In-reply-to: <20190329135859.27529-6-o.rempel@pengutronix.de>
Mail-followup-to: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>, mkl@xxxxxxxxxxxxxx, wg@xxxxxxxxxxxxxx, kernel@xxxxxxxxxxxxxx, linux-can@xxxxxxxxxxxxxxx, robin@xxxxxxxxxxx, david@xxxxxxxxxxx
References: <20190329135859.27529-1-o.rempel@pengutronix.de> <20190329135859.27529-6-o.rempel@pengutronix.de>
User-agent: Mutt/1.5.22 (2013-10-16)

On vr, 29 mrt 2019 14:58:39 +0100, Oleksij Rempel wrote:
> Only connect() should modify jsk->addr.dst_pgn. Setting
> it in bind() is buggy.

Having assymetric PGN's is better. well done!

References:
- [PATCH v1 00/25] UAPI rework
  - From: Oleksij Rempel
- [PATCH v1 05/25] j1939: socket: introduce local_pgn and set in bind()
  - From: Oleksij Rempel

Prev by Date: Re: [PATCH v1 09/25] j1939: socket: add j1939_sk_match_dst
Next by Date: Re: [PATCH v1 04/25] j1939: rename addr.pgn to addr.dst_pgn
Previous by thread: [PATCH v1 05/25] j1939: socket: introduce local_pgn and set in bind()
Next by thread: [PATCH v1 04/25] j1939: rename addr.pgn to addr.dst_pgn
Index(es):
- Date
- Thread

[Index of Archives] [Automotive Discussions] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API] [CAN Bus]

Powered by Linux