Hello Dan, I will have a closer look end of this week! Wolfgang. Am 21.02.19 um 17:24 schrieb Dan Murphy: > Bump > > On 2/14/19 12:27 PM, Dan Murphy wrote: >> Hello >> >> OK I did not give up on this patch series just got a little preoccupied with >> some other kernel work. But here is the update per the comments. >> >> It should be understood I broke these out for reviewability. >> For instance the first patch does not compile on its own as including this >> patch should not change the current functionality and it pulls all the io-mapped >> code from the m_can base file to a platfrom file. >> >> The next patch "Migrate the m_can code to use the framework" >> is the change to the kernel for the io-mapped conversion from a flat file to use >> the framework. Finally the rename patch just renames the m_can_priv to >> m_can_classdev. I broke this change out specifically for readability of the >> migration patch per comments on the code. >> >> AFAIC the first 3 patches can all be squashed into a single patch. Or the >> first 2 patches in the series can be re-arranged but then m_can functionality is >> affected in the migration patch. >> >> Again the first 3 patches here are all just for readability and review purposes. >> >> Dan >> >> Dan Murphy (5): >> can: m_can: Create a m_can platform framework >> can: m_can: Migrate the m_can code to use the framework >> can: m_can: Rename m_can_priv to m_can_classdev >> dt-bindings: can: tcan4x5x: Add DT bindings for TCAN4x5X driver >> can: tcan4x5x: Add tcan4x5x driver to the kernel >> >> .../devicetree/bindings/net/can/tcan4x5x.txt | 37 + >> drivers/net/can/m_can/Kconfig | 14 +- >> drivers/net/can/m_can/Makefile | 2 + >> drivers/net/can/m_can/m_can.c | 788 +++++++++--------- >> drivers/net/can/m_can/m_can.h | 159 ++++ >> drivers/net/can/m_can/m_can_platform.c | 198 +++++ >> drivers/net/can/m_can/tcan4x5x.c | 531 ++++++++++++ >> 7 files changed, 1320 insertions(+), 409 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/net/can/tcan4x5x.txt >> create mode 100644 drivers/net/can/m_can/m_can.h >> create mode 100644 drivers/net/can/m_can/m_can_platform.c >> create mode 100644 drivers/net/can/m_can/tcan4x5x.c >> > >