Thanks for confirming, Marcel. I will come back with the modified patch based on your feedback. On Thu, May 21, 2020 at 12:02 AM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > > Hi Sonny, > > > I am okay with Types = ["le", "bredr"]. However, I don't understand > > why a user should be able to change the Type, since this property > > describes the fact about a peer device, not a local adapter. What does > > it mean by a user changing the type of a peer device? Also, I don't > > understand why HS needs to be considered in that property, since I see > > org.bluez.Device1 objects as discovered devices either through Inquiry > > (in which case it'd be "bredr") or Advertisement (in which case it'd > > be "le"), or both. HS seems to be one of remote features rather than a > > type. Also the HS information is also not readily available in the > > struct btd_device, or even src/device.c, which suggests that it has > > been treated differently. > > you are correct. I was thinking about the local role. My bad. > > Regards > > Marcel >
