Thanks for the feedback, Marcel. Will come back with the modified
patches based on your suggestions.
On Thu, Apr 9, 2020 at 11:12 AM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote:
>
> Hi Sonny,
>
> > This allows us to gather information about whether a device
> > supports BR/EDR, BLE, or both. It appears as DBus Property
> > "Type" on the org.bluez.Device1 interface.
> > ---
> > doc/device-api.txt | 5 +++++
> > src/device.c | 31 +++++++++++++++++++++++++++++++
> > 2 files changed, 36 insertions(+)
>
> my preference is not to combine API documentation patches with code.
>
> >
> > diff --git a/doc/device-api.txt b/doc/device-api.txt
> > index 65d8fee37..ceb68d2f6 100644
> > --- a/doc/device-api.txt
> > +++ b/doc/device-api.txt
> > @@ -158,6 +158,11 @@ Properties string Address [readonly]
> >
> > The Bluetooth class of device of the remote device.
> >
> > + string Type [readonly, optional]
> > +
> > + The carriers supported by this remote device. If it
> > + exists, it can be one of "BR/EDR", "LE", or "DUAL".
> > +
>
> So all values need to be lower case. That is just how we design all API.
>
> If we do this, then I think the name “Bearer” might be better. Also it might be better as array{string} actually.
>
> Regards
>
> Marcel
>
