On Wed, 2020-01-08 at 19:17 +0100, Michał Lowas-Rzechonek wrote:
> Brian, Rafał,
>
> On 01/08, Gix, Brian wrote:
> > > - if (ivu != net->iv_update || local_iv_index != net->iv_index) {
> > > + if (ivu != net->iv_update || iv_index != net->iv_index) {
> >
> > Would it be fair to say that this is the *only* change to the code that fixes the logic that was
> > malfunctioning?
>
> That's correct.
>
> > If so, I would like to shrink this patch to just:
> >
> > - if (ivu != net->iv_update || local_iv_index != net->iv_index) {
> > + if (ivu != local_ivu || iv_index != local_iv_index) {
> >
> > or, breaking this into a 2-patch patchset, where one of the patches removes the local caching of ivu and
> > ivi,
> > and the second patch fixes the actual bug.
>
> Ok, let's split this into 2 separate patches. I still think this "local
> caching" was the underlying cause of the mistake.
It probably makes more sense for the *first* patch of the set to fix the logic error,
and with the second patch, remove the local caching... Otherwise the cache removal
patch will include the absurdity of comparing net->iv_index against itself.
>
> regards
