Re: [PATCH BlueZ] mesh: Fix IV recovery

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Brian, Rafał,

On 01/08, Gix, Brian wrote:
> > -	if (ivu != net->iv_update || local_iv_index != net->iv_index) {
> > +	if (ivu != net->iv_update || iv_index != net->iv_index) {
> 
> Would it be fair to say that this is the *only* change to the code that fixes the logic that was
> malfunctioning?

That's correct.

> 
> If so, I would like to shrink this patch to just:
> 
> -	if (ivu != net->iv_update || local_iv_index != net->iv_index) {
> +	if (ivu != local_ivu || iv_index != local_iv_index) {
>
> or, breaking this into a 2-patch patchset, where one of the patches removes the local caching of ivu and ivi,
> and the second patch fixes the actual bug.

Ok, let's split this into 2 separate patches. I still think this "local
caching" was the underlying cause of the mistake.

regards
-- 
Michał Lowas-Rzechonek <michal.lowas-rzechonek@xxxxxxxxxxx>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux