On Mon, Feb 18, 2019 at 4:28 PM Vasily Khoruzhick <anarsoul@xxxxxxxxx> wrote: > > On Mon, Feb 18, 2019 at 2:08 PM Stefan Wahren <stefan.wahren@xxxxxxxx> wrote: > > > > Hi Vasily, > > Hi Stefan, > > > > Vasily Khoruzhick <anarsoul@xxxxxxxxx> hat am 18. Februar 2019 um 22:24 geschrieben: > > > > > > > > > On Mon, Feb 18, 2019 at 1:10 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > > > > > > > On Fri, Jan 18, 2019 at 09:02:27AM -0800, Vasily Khoruzhick wrote: > > > > > Add binding document for bluetooth part of RTL8723BS/RTL8723CS > > > > > > > > > > Signed-off-by: Vasily Khoruzhick <anarsoul@xxxxxxxxx> > > > > > --- > > > > > .../bindings/net/rtl8723bs-bluetooth.txt | 35 +++++++++++++++++++ > > > > > 1 file changed, 35 insertions(+) > > > > > create mode 100644 Documentation/devicetree/bindings/net/rtl8723bs-bluetooth.txt > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/net/rtl8723bs-bluetooth.txt b/Documentation/devicetree/bindings/net/rtl8723bs-bluetooth.txt > > > > > new file mode 100644 > > > > > index 000000000000..8357f242ae4c > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/net/rtl8723bs-bluetooth.txt > > > > > @@ -0,0 +1,35 @@ > > > > > +RTL8723BS/RTL8723CS Bluetooth > > > > > +--------------------- > > > > > + > > > > > +RTL8723CS/RTL8723CS is WiFi + BT chip. WiFi part is connected over SDIO, while > > > > > +BT is connected over serial. It speaks H5 protocol with few extra commands > > > > > +to upload firmware and change module speed. > > > > > + > > > > > +Required properties: > > > > > + > > > > > + - compatible: should be one of the following: > > > > > + * "realtek,rtl8723bs-bt" > > > > > + * "realtek,rtl8723cs-bt" > > > > > +Optional properties: > > > > > + > > > > > + - device-wake-gpios: GPIO specifier, used to wakeup the BT module (active high) > > > > > + - enable-gpios: GPIO specifier, used to enable the BT module (active high) > > > > > + - host-wake-gpios: GPIO specifier, used to wakeup the host processor (active high) > > > > > + - firmware-postfix: firmware postfix to be used for firmware config > > > > > > > > sorry, i didn't noticed your great series before. David and i working at the same stuff but for the Asus Tinker Board. > > > > I created a similiar yet untested patch version for hci_h5 [1]. Maybe it's useful. > > Looks good to me, but you may need to add firmware-postfix. > > > Just a comment about the binding. It's really necessary to add the reset-gpio? Can't we use the enable-gpio with inverse polarity for this? > > Yes, we can use enable-gpio instead of reset-gpio on pine64 and pinebook. Then why do we have both? Reset and enable are distinct. The inverse of enable-gpios is typically powerdown-gpios, not reset-gpios. Rob
