Hi Marcel, On Mon, Feb 18, 2019 at 11:48:21AM +0100, Marcel Holtmann wrote: > Hi Matthias, > > > [initial post: https://lore.kernel.org/patchwork/cover/1028184/] > > > > On some systems the Bluetooth Device Address (BD_ADDR) isn't stored > > on the Bluetooth chip itself. One way to configure the address is > > through the device tree (patched in by the bootloader). The btqcomsmd > > driver is an example, it can read the address from the DT property > > 'local-bd-address'. > > > > To avoid redundant open-coded reading of 'local-bd-address' and error > > handling this series adds the quirk HCI_QUIRK_USE_BDADDR_PROPERTY to > > retrieve the BD address of a device from the DT and adapts the > > btqcomsmd and hci_qca drivers to use this quirk. > > > > Matthias Kaehlcke (3): > > Bluetooth: Add quirk for reading BD_ADDR from fwnode property > > Bluetooth: btqcomsmd: use HCI_QUIRK_USE_BDADDR_PROPERTY > > Bluetooth: hci_qca: Set HCI_QUIRK_USE_BDADDR_PROPERTY for wcn3990 > > > > drivers/bluetooth/btqcomsmd.c | 29 +++-------------------- > > drivers/bluetooth/hci_qca.c | 1 + > > include/net/bluetooth/hci.h | 12 ++++++++++ > > net/bluetooth/hci_core.c | 43 +++++++++++++++++++++++++++++++++++ > > net/bluetooth/mgmt.c | 6 +++-- > > 5 files changed, 63 insertions(+), 28 deletions(-) > > I am getting compiler warnings when trying to apply this set: > > CC drivers/bluetooth/btqcomsmd.o > drivers/bluetooth/btqcomsmd.c: In function ‘btqcomsmd_setup’: > drivers/bluetooth/btqcomsmd.c:120:6: warning: unused variable ‘err’ [-Wunused-variable] > int err; > ^~~ > drivers/bluetooth/btqcomsmd.c:118:20: warning: unused variable ‘btq’ [-Wunused-variable] > struct btqcomsmd *btq = hci_get_drvdata(hdev); > ^~~ Sorry, I missed that the variables aren't used anymore. I'll send a new version soon. Thanks Matthias
