Re: [RFC] Bluetooth: hci_ll: Convert to use h4_recv_buf helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Marcel Holtmann <marcel@xxxxxxxxxxxx> [180320 21:01]:
> Hi Tony,
> 
> >>>> The HCILL or eHCILL protocol from TI is actually an H:4 protocol with a
> >>>> few extra events and thus can also use the h4_recv_buf helper. Instead
> >>>> of open coding the same funtionality add the extra events to the packet
> >>>> description table and use h4_recv_buf.
> >>>> 
> >>>> Signed-off-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>
> >>>> ---
> >>>> drivers/bluetooth/Kconfig  |   1 +
> >>>> drivers/bluetooth/hci_ll.c | 214 +++++++++++++++------------------------------
> >>>> 2 files changed, 70 insertions(+), 145 deletions(-)
> >>> 
> >>> is anybody able to test this change for me and verify that it doesn’t break things.
> >> 
> >> The diffstat looks nice :) I can give it a test on Motorola Droid 4
> >> later this week. If you want feedback a bit earlier, maybe Tony
> >> can give it a try (added to cc).
> > 
> > I tried applying it from the mailing list archive against
> > current Linux next and -rc6 but it failed:
> > 
> > patching file drivers/bluetooth/Kconfig
> > Hunk #1 succeeded at 147 with fuzz 2 (offset -13 lines).
> > patching file drivers/bluetooth/hci_ll.c
> > Hunk #2 succeeded at 88 (offset 4 lines).
> > Hunk #3 FAILED at 364.
> > 
> > Any ideas which patch(es) I might be missing?
> 
> that might be a git am issue and it being rather strict.

Or the patch not being correct copied from the archive.
Do you have a patchwork url for it or care to bounce the
patch to me?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux