Re: [RFC] Bluetooth: hci_ll: Convert to use h4_recv_buf helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Sebastian Reichel <sre@xxxxxxxxxx> [180320 17:30]:
> Hi,
> 
> On Tue, Mar 20, 2018 at 04:50:37PM +0100, Marcel Holtmann wrote:
> > Hi,
> > 
> > > The HCILL or eHCILL protocol from TI is actually an H:4 protocol with a
> > > few extra events and thus can also use the h4_recv_buf helper. Instead
> > > of open coding the same funtionality add the extra events to the packet
> > > description table and use h4_recv_buf.
> > > 
> > > Signed-off-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>
> > > ---
> > > drivers/bluetooth/Kconfig  |   1 +
> > > drivers/bluetooth/hci_ll.c | 214 +++++++++++++++------------------------------
> > > 2 files changed, 70 insertions(+), 145 deletions(-)
> > 
> > is anybody able to test this change for me and verify that it doesn’t break things.
> 
> The diffstat looks nice :) I can give it a test on Motorola Droid 4
> later this week. If you want feedback a bit earlier, maybe Tony
> can give it a try (added to cc).

I tried applying it from the mailing list archive against
current Linux next and -rc6 but it failed:

patching file drivers/bluetooth/Kconfig
Hunk #1 succeeded at 147 with fuzz 2 (offset -13 lines).
patching file drivers/bluetooth/hci_ll.c
Hunk #2 succeeded at 88 (offset 4 lines).
Hunk #3 FAILED at 364.

Any ideas which patch(es) I might be missing?

Regards,

Tony


--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux