On Wed, 2018-01-03 at 14:56 +0100, Lukas Wunner wrote: > On Wed, Jan 03, 2018 at 03:08:59PM +0200, Andy Shevchenko wrote: > > On Tue, 2018-01-02 at 20:08 +0100, Lukas Wunner wrote: > > > - dev_info(dev->dev, "BCM irq: %d\n", dev->irq); > > > + dev_dbg(dev->dev, "BCM irq: %d\n", dev->irq); > > > > Perhaps, instead you may add same check > > > > if (dev->irq > 0) > > dev_info(...); > > else > > dev_info(..., "BCM irq not in use\n"); dev_dbg(..., "... (rc: %d)\n", dev->irq); ? But okay, it's a bikeshedding, when something goes wrong the debug is the first on the plate to enable anyway. > gpiod_to_irq() returns different negative errnos depending on the > exact > error condition. We wouldn't be able to easily differentiate them if > we do it this way. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
