On Tue, 2018-01-02 at 20:08 +0100, Lukas Wunner wrote: > The host wake IRQ is optional, but if none is found, "BCM irq: -22" is > logged which may irritate users. This is really a debug message, so > use > dev_dbg() instead of dev_info(). If users are interested in the IRQ, > they can always consult /proc/interrupts. I object to do in the way how it's done in this patch. See below. > > Cc: Frédéric Danis <frederic.danis.oss@xxxxxxxxx> > Signed-off-by: Lukas Wunner <lukas@xxxxxxxxx> > --- > drivers/bluetooth/hci_bcm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c > index 01d0943b7bbb..632939d413df 100644 > --- a/drivers/bluetooth/hci_bcm.c > +++ b/drivers/bluetooth/hci_bcm.c > @@ -798,7 +798,7 @@ static int bcm_get_resources(struct bcm_device > *dev) > dev->irq = gpiod_to_irq(gpio); > } > > - dev_info(dev->dev, "BCM irq: %d\n", dev->irq); > + dev_dbg(dev->dev, "BCM irq: %d\n", dev->irq); Perhaps, instead you may add same check if (dev->irq > 0) dev_info(...); else dev_info(..., "BCM irq not in use\n"); ? > return 0; > } > -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
