Re: [PATCH v2 06/10] Bluetooth: hci_bcm: Silence IRQ printk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 03, 2018 at 03:08:59PM +0200, Andy Shevchenko wrote:
> On Tue, 2018-01-02 at 20:08 +0100, Lukas Wunner wrote:
> > @@ -798,7 +798,7 @@ static int bcm_get_resources(struct bcm_device
> > *dev)
> >  		dev->irq = gpiod_to_irq(gpio);
> >  	}
> >  
> > -	dev_info(dev->dev, "BCM irq: %d\n", dev->irq);
> > +	dev_dbg(dev->dev, "BCM irq: %d\n", dev->irq);
> 
> Perhaps, instead you may add same check
> 
> if (dev->irq > 0)
>  dev_info(...);
> else
>  dev_info(..., "BCM irq not in use\n");
> 
> ?

gpiod_to_irq() returns different negative errnos depending on the exact
error condition.  We wouldn't be able to easily differentiate them if
we do it this way.

Thanks,

Lukas
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux