On Thu, Dec 28, 2017 at 1:40 PM, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > On Thu, 2017-12-28 at 13:29 +0100, Linus Walleij wrote: >> On Thu, Dec 28, 2017 at 10:26 AM, Andy Shevchenko >> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: >> > On Thu, 2017-12-28 at 10:18 +0100, Lukas Wunner wrote: >> > > On Thu, Dec 28, 2017 at 10:41:17AM +0200, Andy Shevchenko wrote: >> > > > On Tue, 2017-12-26 at 17:07 +0200, Lukas Wunner wrote: > >> > > Hm okay, Documentation/gpio/consumer.txt says: >> > > >> > > Guidelines for GPIOs consumers >> > > ============================== >> > > >> > > Drivers that can't work without standard GPIO calls should >> > > have >> > > Kconfig entries that depend on GPIOLIB. >> > > >> > > So a "depends on GPIOLIB" would be more appropriate, right? >> > >> > Yes, but still wrong for this certain driver. It *can* work w/o >> > GPIOLIB. >> > Now you have done unnecessary dependency for that case. >> >> No I think it should use depends on GPIOLIB. >> >> The reason is that the driver uses unconditional devm_gpiod_get(), >> not devm_gpiod_get_optional(). > > How come? > I just checked the code, all three use _optional() variant. > > I checked in bcm_get_resources(). I'm as confused as you are :D The patch says: > Loading hci_bcm with CONFIG_GPIOLIB=n results in the following splat > when calling gpiod_to_irq() from bcm_get_resources(): Which leads to bcm and it is correct as you state it, but it patches: > diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig > index 45a2f59cd935..41932f0e68d0 100644 > --- a/drivers/bluetooth/Kconfig > +++ b/drivers/bluetooth/Kconfig > @@ -110,6 +110,7 @@ config BT_HCIUART_NOKIA > depends on PM > select BT_HCIUART_H4 > select BT_BCM > + select GPIOLIB And BT_HCIUART_NOKIA compiles drivers/bluetooth/hci_nokia.c which does depend on GPIOLIB. Apart from selectng BT_BCM. So I suspect the descripton and/or patch is wrong... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
