On Thu, 2017-12-28 at 13:29 +0100, Linus Walleij wrote: > On Thu, Dec 28, 2017 at 10:26 AM, Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Thu, 2017-12-28 at 10:18 +0100, Lukas Wunner wrote: > > > On Thu, Dec 28, 2017 at 10:41:17AM +0200, Andy Shevchenko wrote: > > > > On Tue, 2017-12-26 at 17:07 +0200, Lukas Wunner wrote: > > > Hm okay, Documentation/gpio/consumer.txt says: > > > > > > Guidelines for GPIOs consumers > > > ============================== > > > > > > Drivers that can't work without standard GPIO calls should > > > have > > > Kconfig entries that depend on GPIOLIB. > > > > > > So a "depends on GPIOLIB" would be more appropriate, right? > > > > Yes, but still wrong for this certain driver. It *can* work w/o > > GPIOLIB. > > Now you have done unnecessary dependency for that case. > > No I think it should use depends on GPIOLIB. > > The reason is that the driver uses unconditional devm_gpiod_get(), > not devm_gpiod_get_optional(). How come? I just checked the code, all three use _optional() variant. I checked in bcm_get_resources(). > > The only thing you achieve if you do not have a GPIOLIB is a driver > that always exits probe with an error. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
