Hi Marcel,
On Tue, Oct 24, 2017, Marcel Holtmann wrote:
> > index 1fba2a0..58045ee 100644
> > --- a/net/bluetooth/mgmt.c
> > +++ b/net/bluetooth/mgmt.c
> > @@ -6383,6 +6383,7 @@ static int remove_advertising(struct sock *sk, struct hci_dev *hdev,
> > if (skb_queue_empty(&req.cmd_q) ||
> > !hdev_is_powered(hdev) ||
> > hci_dev_test_flag(hdev, HCI_ADVERTISING)) {
> > + skb_queue_purge(&req.cmd_q);
> > rp.instance = cp->instance;
> > err = mgmt_cmd_complete(sk, hdev->id,
> > MGMT_OP_REMOVE_ADVERTISING,
>
> this does not look right to me. It most likely has side affects. The
> fix must be differently if there is a memory leak.
Actually, it looks like the right fix to me. We don't have a separate
helper to clean up a hci_request that never got used, and
skb_queue_purge is what other places in the code seem to be doing in
this kind of cases.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
