Hi Jaganath,
> If command is added to req then it should be freed in case if
> hdev is down or HCI_ADVERTISING flag is not set.
>
> Signed-off-by: Jaganath Kanakkassery <jaganathx.kanakkassery@xxxxxxxxx>
> ---
> net/bluetooth/mgmt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index 1fba2a0..58045ee 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -6383,6 +6383,7 @@ static int remove_advertising(struct sock *sk, struct hci_dev *hdev,
> if (skb_queue_empty(&req.cmd_q) ||
> !hdev_is_powered(hdev) ||
> hci_dev_test_flag(hdev, HCI_ADVERTISING)) {
> + skb_queue_purge(&req.cmd_q);
> rp.instance = cp->instance;
> err = mgmt_cmd_complete(sk, hdev->id,
> MGMT_OP_REMOVE_ADVERTISING,
this does not look right to me. It most likely has side affects. The fix must be differently if there is a memory leak.
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
