Hi Bastien, On Tue, Oct 24, 2017 at 1:13 AM, Bastien Nocera <hadess@xxxxxxxxxx> wrote: > On Mon, 2017-10-23 at 23:39 +0300, Luiz Augusto von Dentz wrote: >> Hi Bastian, >> >> On Mon, Oct 23, 2017 at 6:48 PM, Bastien Nocera <hadess@xxxxxxxxxx> >> wrote: >> > The Battery Service characteristics are not children of the HoG >> > characteristics, so there's nothing to consume in the input >> > profile. >> > Remove that code which duplicated most of the battery profile >> > plugin. >> >> Id rather not do this, we actually do intend the maintain a small >> helper library that can be unit tested, what bt_bas lacks is just >> proper support of bt_gatt_client nothing else. Also for the record >> this would probably break BfA HoG qualification which requires >> battery >> service to be supported as well, Android code does not have any other >> bas implementation. > > That's fine, we can leave this file around. What about the other > patches? Id move the code around bt_gatt_client to bt_bas and let it handle the internal details, the long term plan is to get rid of GAttrib so perhaps we should start with bas. -- Luiz Augusto von Dentz -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
