Resent because of MUA error: On 30/06/17 22:27, Marcel Holtmann wrote: > Hi Ian, >> It seems there is a fair bit of commonality among the h4 based >> bluetooth drivers - probably better to abstract it out and make a >> h4 core around which the other serdev and ldisc drivers could sit? > > don't try to overthink this. The code is already abstracted and > optimized. Add the serdev support to hci_bcm.c and do not try to mess > with the hci_nokia.c. That one is a total different driver and it is > special in its own way. It doesnt *look* terribly special - there are a few extra entries in nokia_recv_pkts[] along with their helper functions - but its otherwise very similar indeed... I'm happy to add the code to hci_bcm, but it looks like theres a fair bit of code duplication across at least these two drivers... -Ian -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
