Hi Ian, >>> If you have an embedded board with a proper DT definition, and the >>> UART is hard-wired to the Bluetooth chip, then go for serdev. It >>> means no btattach is needed. The kernel will enumerate this properly >>> for you. That is the way forward. Someone needed to adapt the >>> hci_bcm.c driver for this anyway. It just happens that you are the >>> first one. >> >> Right - I'll follow that route and add serdev support to hci_bcm.c then! > > Hmm. ok, this gets to be a bitof a rabbit-hole. > > the hci-nokia driver is *extremely* similar in operation to the hci_bcm > driver, other than being serdev based. even the firmware loading is > "broadcom style", so I dont really see why it needs another driver, > other than its been coded to one chip and a few small nokia-specific > bits in it. > > It seems there is a fair bit of commonality among the h4 based bluetooth > drivers - probably better to abstract it out and make a h4 core around > which the other serdev and ldisc drivers could sit? don’t try to overthink this. The code is already abstracted and optimized. Add the serdev support to hci_bcm.c and do not try to mess with the hci_nokia.c. That one is a total different driver and it is special in its own way. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
