On Wed, Oct 5, 2011 at 6:43 PM, Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> wrote: > Hi, > > On Wed, Oct 5, 2011 at 7:12 PM, Slawomir Bochenski <lkslawek@xxxxxxxxx> wrote: >> On Wed, Oct 5, 2011 at 5:38 PM, Luiz Augusto von Dentz >> <luiz.dentz@xxxxxxxxx> wrote: >>> I don't think this is true, if it was then why would we call >>> service->put on the end of stream and I also never see this happening >>> in practice e.g. calling ftp_put in the end of stream. >> >> Actually, if you will add DBG call to filesystem_write() you will >> clearly see, that ftp_put is called at the end of stream. > > That is true only if the body is not bigger than the MTU, in other > words the body is not fragmented, otherwise it would be pointless to > check for name and folder only at the very end of the stream. False. You check the name and folder after OBEX_EV_REQCHECK, which was specificaly added to allow earlier checks. > I also > don't like the fact that OBEX_EV_REQ is generated in the end of the > first package, it is really confusing that a request event comes after > its data, but maybe there is a reason for that or the intention was > not that so we are not handling the event the way it was meant? OBEX_EV_REQ is delivered when the remote party finished sending request, not after first OBEX packet. This is the way it is intented in OpenOBEX. Please do check it or consult OpenOBEX code/documentation. If you still do not agree, please to present an actual case when this won't work. Please do try first with a transfer larger than the MTU before assuming anything (maximum MTU is 64K, send a larger file), -- Slawomir Bochenski -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
