Re: [PATCH obexd 4/4] Simplify code for calling mime driver flush()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Oct 5, 2011 at 7:12 PM, Slawomir Bochenski <lkslawek@xxxxxxxxx> wrote:
> On Wed, Oct 5, 2011 at 5:38 PM, Luiz Augusto von Dentz
> <luiz.dentz@xxxxxxxxx> wrote:
>> I don't think this is true, if it was then why would we call
>> service->put on the end of stream and I also never see this happening
>> in practice e.g. calling ftp_put in the end of stream.
>
> Actually, if you will add DBG call to filesystem_write() you will
> clearly see, that ftp_put is called at the end of stream.

That is true only if the body is not bigger than the MTU, in other
words the body is not fragmented, otherwise it would be pointless to
check for name and folder only at the very end of the stream. I also
don't like the fact that OBEX_EV_REQ is generated in the end of the
first package, it is really confusing that a request event comes after
its data, but maybe there is a reason for that or the intention was
not that so we are not handling the event the way it was meant?

-- 
Luiz Augusto von Dentz
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux