Re: [PATCH obexd 4/4] Simplify code for calling mime driver flush()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> By removing this it wont flush on EOS, so Im not sure why you removed
> it since OBEX_EV_REQ is only generated for the request not for the
> streams itself. Actually if OpenOBEX had an event for that represent
> the FINAL bit that would solve the problem with unknown size, but for
> gobex this is exposed directly in the callback so I wouldn't change
> that now.
>
>
> You got this wrong, the purpose of this code is to flush on end of
> stream not in the beginning/put request, so if we have consecutive
> puts the last packet should cause a flush so the driver can sync any
> buffered data before close which needs to be immediately.

Again, OBEX_EV_REQ will be the very _last_ thing called. This code
flushes after all write()-s. After the final packet.


-- 
Slawomir Bochenski
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux