Hi Johan
-----Original Message-----
From: Johan Hedberg
Sent: Friday, September 09, 2011 7:35 AM
To: David Stockwell
Cc: Lucas De Marchi ; linux-bluetooth@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 3/5] avrcp: get/set three-byte company-id
Hi David,
On Fri, Sep 09, 2011, David Stockwell wrote:
A short cut: the output is a contiguous array of uint_8, so masking
with 0xFF should be unnecessary. Would this be required for non-x86
(including x86_64) architectures?
Firstly, please don't top-post on this mailing list.
+++++ Sorry...I am quite entrenched in the .Net world by day, so I forgot.
Then did not send an apology afterwards.
If you don't do "& 0xff" and the value you're trying to assign to cid[n]
is greater than 0xff isn't the result of the integer overflow that
follows essentially the same as if you had done "% (0xff + 1)" (which is
not what you want in this case).
+++++ I saw the rest of the discussion...cheers.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth"
in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
