A short cut: the output is a contiguous array of uint_8, so masking with
0xFF should be unnecessary. Would this be required for non-x86 (including
x86_64) architectures?
DS
-----Original Message-----
From: Johan Hedberg
Sent: Friday, September 09, 2011 5:41 AM
To: Lucas De Marchi
Cc: linux-bluetooth@xxxxxxxxxxxxxxx ; David Stockwell
Subject: Re: [PATCH 3/5] avrcp: get/set three-byte company-id
Hi,
On Thu, Sep 08, 2011, Lucas De Marchi wrote:
+static void set_company_id(uint8_t cid[3], const uint32_t cid_in)
+{
+ cid[0] = cid_in >> 16;
+ cid[1] = cid_in >> 8;
+ cid[2] = cid_in;
+}
You seem to have forgotten the "& 0xff" part here. Other than that I
didn't seen any obvious issues in the patch set.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
