Re: [PATCH 0/3] RFC: prioritizing data over HCI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Luiz -

On Wed, 10 Aug 2011, Luiz Augusto von Dentz wrote:

Hi Mat,

On Wed, Aug 10, 2011 at 8:38 PM, Mat Martineau <mathewm@xxxxxxxxxxxxxx> wrote:
+struct hci_chan {
+       struct list_head list;
+       struct hci_conn *conn;
+       struct sk_buff_head data_q;
+       unsigned int    sent;
+}

At the BlueZ summit last year, the group settled on using an "HCI channel"
as an abstraction for AMP logical links.  We have a hci_chan struct already
that you could add to.  Before making changes to HCI data structures, could
we first work on upstreaming the AMP HCI changes (which also include some
QoS-related code)?

If just you told us this before I would have not spend time
implementing it, so could you please sent this patches ASAP, otherwise
I will just send mine that just address the prioritization

Your RFC patches for prioritized HCI queues are not in conflict with the AMP code. It's just the proposed hci_chan structure that came up in this email thread.

My recent patches are the beginning of AMP upstreaming. I was trying to get the generic L2CAP improvements in place first. One of my coworkers is starting to work in parallel on upstreaming the HCI changes, but we need to create a suitable patch series for bluetooth-next.


Btw, the thread intent is perhaps becoming too broad,  we should focus
in small steps lets say first HCI Channel, then we continue from
there.

I agree, it's hard to keep track of the various sub-threads at this point. The HCI channel is a good place to start.


--
Mat Martineau
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Bluez Devel]     [Linux Wireless Networking]     [Linux Wireless Personal Area Networking]     [Linux ATH6KL]     [Linux USB Devel]     [Linux Media Drivers]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Big List of Linux Books]

  Powered by Linux