On Fri, 5 Aug 2011, Gustavo Padovan wrote:
* Peter Hurley <peter@xxxxxxxxxxxxxxxxxx> [2011-08-04 19:09:37 -0400]:
Hi Mat,
On Thu, 2011-08-04 at 13:37 -0400, Mat Martineau wrote:
I had a recent discussion with Gustavo about HCI queuing issues with
ERTM:
http://www.spinics.net/lists/linux-bluetooth/msg13774.html
My proposal is to move tx queuing up to L2CAP, and have the HCI tx
task only handle scheduling. Senders would tell HCI they have data to
send, and HCI would call back to pull data. I've been focused on
L2CAP - it would be possible to make a similar queuing change to
SCO/eSCO/LE, but not strictly necessary.
Would you please clarify this approach (perhaps in a separate thread)?
For example, how does having tx queues in l2cap_chan (instead of the
hci_conn) solve the latency problems in ERTM when replying to
REJ/SREJ/poll? Won't there potentially be just as much data already
queued up? Is the plan to move the reply to the front of the tx queue
because reqseq won't need to be assigned until the frame is actually
pulled off the queue?
Exactly. ERTM connections can get dropped if the too much data is buffered and
we need to send final bit for example.
Right now, an outgoing ERTM frame goes through two queues: a
channel-specific ERTM tx queue and the HCI ACL data_q. The ERTM
control field is not constructed until a frame is removed from the
ERTM tx queue and pushed to the HCI data_q, so the s-frame latency
problem comes in when the the HCI data_q gets deep. S-frames are
already pushed directly in to the HCI data_q, bypassing the data tx
queue.
From an ERTM perspective, the goal is to defer assignment of reqseq
and f-bit values as late as possible, so the remote device gets the
most recent information on data frames and polls that have been
received. The optimal thing to do (by this measurement, anyway) is to
build the ERTM control field as data is sent to the baseband -- in
other words, to eliminate the HCI data_q altogether.
(Yeah, without the data_q, ERTM would need additional queues for
s-frames and retransmitted i-frames)
So, without a data_q, what makes sense? If there are ACL buffers
available and no pending L2CAP senders, it would be great to push data
straight out to the baseband. If we're blocked waiting for
num_completed_packets, then receipt of num_completed_packets is the
natural time to pull data from the tx queues that now happen to be up
in the L2CAP layer.
There are certainly locking, task scheduling, data scheduling, QoS,
and efficiency issues to consider. This is just a general description
for now, and I'm trying to see if there's enough interest (or few
enough obvious gotchas) to put some serious effort in to moving
forward.
This is different from the problem you're solving, but as long as
we're talking about big changes to HCI tx, I think we could make some
changes that help out with prioritization and queuing across all
channels (whether they're going to the same remote device or different
remote devices).
It could be more efficient to schedule this way since HCI wouldn't
have to iterate over all of the connections and queues - it would only
have to review the prioritized list of pending sends. Might be a more
fitting structure for QoS too.
Wouldn't this 'prioritized list of pending sends' need to be locked to
prevent update while reading? ISTM that contention might be fairly high
for a single, shared resource like that.
If there was a prioritized list that was manipulated on multiple
threads, then a lock certainly would be required. Maybe it would work
to keep the information sent between threads pretty simple (just an "I
have data" bit), then any complex lists could be manipulated in a more
controlled HCI-only context. The prioritization code could run only
when processing num_completed_packets.
Thanks for the great feedback so far! Seeing any major flaws at this
high level?
Regards,
--
Mat Martineau
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
