Hi Archie, On Sun, Aug 21, 2022 at 11:33 PM Archie Pusaka <apusaka@xxxxxxxxxx> wrote: > > Hi Paul, > > On Mon, 22 Aug 2022 at 14:15, Paul Menzel <pmenzel@xxxxxxxxxxxxx> wrote: > > > > Dear Archie, > > > > > > Thank you for the patch. > > > > > > Am 22.08.22 um 06:53 schrieb Archie Pusaka: > > > From: Archie Pusaka <apusaka@xxxxxxxxxxxx> > > > > I think the tag in the email subject needs to be [PATCH BlueZ] to be > > detected by the build bot. > > Is the bot the one who just commented about the test result? If so > probably it can detect this format as well. > > > > > We set the pending settings flag when sending MGMT_SETTING_* > > > commands to the MGMT layer and clear them when receiving success > > > reply, but we don't clear them when receiving error reply. This > > > might cause a setting to be stuck in pending state. > > > > Were you able to reproduce a problem on real hardware? > > I only received some reports, but unfortunately I cannot repro on real > hardware. The symptom is BlueZ can't be turned off, snoop logs shows > that MGMT_OP_SET_POWERED fails to be sent, and we are stuck with it > since the next commands to toggle power are ignored. Weird how can you tell MGMT_OP_SET_POWERED fails to be sent or you meant it was sent but the kernel returned an error? It would be great to include these errors. > > > > > Therefore, also clear the pending flag when receiving error. > > > Furthermore, this patch also postpone setting the pending flag > > > > postpone*s* > > Thanks, will fix. > > > > > until we queue the MGMT command in order to avoid setting it too > > > soon but we return early. > > > > Maybe add a comment, that how you tested this? > > The reporter claims the problem is no longer observable after this > patch. I didn't do any other intelligent way of testing, > unfortunately. Do I also need to document that? > > > > > Reviewed-by: Sonny Sasaka <sonnysasaka@xxxxxxxxxxxx> > > > > > > --- > > > > > > src/adapter.c | 45 +++++++++++++++++++++++++++++++++++++-------- > > > 1 file changed, 37 insertions(+), 8 deletions(-) > > > > […] > > > > > > Kind regards, > > > > Paul -- Luiz Augusto von Dentz
