Dear Archie, Thank you for the patch. Am 22.08.22 um 06:53 schrieb Archie Pusaka:
From: Archie Pusaka <apusaka@xxxxxxxxxxxx>
I think the tag in the email subject needs to be [PATCH BlueZ] to be detected by the build bot.
We set the pending settings flag when sending MGMT_SETTING_* commands to the MGMT layer and clear them when receiving success reply, but we don't clear them when receiving error reply. This might cause a setting to be stuck in pending state.
Were you able to reproduce a problem on real hardware?
Therefore, also clear the pending flag when receiving error. Furthermore, this patch also postpone setting the pending flag
postpone*s*
until we queue the MGMT command in order to avoid setting it too soon but we return early.
Maybe add a comment, that how you tested this?
Reviewed-by: Sonny Sasaka <sonnysasaka@xxxxxxxxxxxx> --- src/adapter.c | 45 +++++++++++++++++++++++++++++++++++++-------- 1 file changed, 37 insertions(+), 8 deletions(-)
[…] Kind regards, Paul
