Hi Szymon,
On Tue, Nov 16, 2010, Szymon Janc wrote:
> +#define REQUEST_TIMEOUT (10 * 1000) /* 10 seconds */
Are you sure 10 seconds is enough. What if the provider does user
interaction? In that case I suppose 30 seconds or even a minute (which I
think we use elsewhere for user interaction) would be better.
> +static DBusMessage *register_provider(DBusConnection *conn, DBusMessage *msg,
> + void *data)
> +{
> + const char *path;
> + const char *name;
Just combine these on the same line.
> +static DBusMessage *unregister_provider(DBusConnection *conn, DBusMessage *msg,
> + void *data)
> +{
> + const char *path;
> + const char *name;
Same here.
> + if (!provider || !g_str_equal(provider->path, path)
> + || !g_str_equal(provider->name, name))
> + return g_dbus_create_error(msg, ERROR_INTERFACE ".DoesNotExist",
> + "No such OOB provider registered");
Same thing about line splitting and || as I mentioned in the other
email, i.e. line break comes after || and not before it.
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
