Hi Szymon,
On Tue, Nov 16, 2010, Szymon Janc wrote:
> +Service org.bluez
> +Interface org.bluez.OOB
> +Object path /org/bluez
I think this should use the same path as the Manager API, which at the
moment is /
> +Methods void RegisterProvider(object provider)
> +
> + This method registers provider for DBus OOB plug-in.
> + When provider is successfully registered plug-in becomes
> + active. Only one provider can be registered at time.
> +
> + Possible errors: org.bluez.Error.AlreadyExists
> +
> + void UnregisterProvider(object provider)
> +
> + This method unregisters provider for DBus OOB plug-in.
> +
> + Possible errors: org.bluez.Error.DoesNotExist
Ok, these methods make sense.
> + array{byte} hash, array{byte} randomizer
> + ReadLocalOobData(object adapter)
Having to pass an adapter path as a parameter seems weird. Wouldn't it
make more sense to have this method in the Adapter path/interface
instead? Also, we could toy around with the thought of putting the two
other methods into the current Manager interface.
One general thing throughout your patches, both the in-code comments and
commit messages: D-Bus is spelled D-Bus, not DBus :)
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
