Hi Johan, > > src/btio.h | 3 --- > > src/log.h | 4 +--- > > 2 files changed, 1 insertions(+), 6 deletions(-) > > > > diff --git a/src/btio.h b/src/btio.h > > index 00d743e..fa6ff69 100644 > > --- a/src/btio.h > > +++ b/src/btio.h > > @@ -21,8 +21,6 @@ > > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > > * > > */ > > -#ifndef BT_IO_H > > -#define BT_IO_H > > I think it'd be good to leave this for BtIO since it might become a > public library soon. > > > -#ifndef __LOGGING_H > > -#define __LOGGING_H > > +extern int debug_enabled; > > This doesn't match the commit message. To me it seems like the extern > int addition should be part of the third patch and not this one. Also, > Marcel might have had a reason for putting the safeguard for log.h so > just leave these safeguards as they are (ofono and connman has them > too). that safeguard can be removed. That was some leftover from when it looked like a good idea to make this more generic. It never worked out so lets just remove this. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
