Hi Johan, > > Issues found by smatch static check: http://smatch.sourceforge.net/ > > --- > > sbc/sbc.c | 3 +-- > > sbc/sbcdec.c | 9 +++------ > > 2 files changed, 4 insertions(+), 8 deletions(-) > > > > diff --git a/sbc/sbc.c b/sbc/sbc.c > > index edd152f..86399dd 100644 > > --- a/sbc/sbc.c > > +++ b/sbc/sbc.c > > @@ -1138,8 +1138,7 @@ void sbc_finish(sbc_t *sbc) > > if (!sbc) > > return; > > > > - if (sbc->priv_alloc_base) > > - free(sbc->priv_alloc_base); > > + free(sbc->priv_alloc_base); > > I'm a bit hesitant at removing these NULL checks since older libc > versions might need them. Any comments from Marcel? this is just fine. If you have such an old libc version that doesn't do it, then you have a problem anyway. I am also not sure that this is a problem with any libc version at all. The only argument that might hold this is if you wanna compile this for a non GNU platform. I don't even know if that is possible since I actually don't care about non Linux platforms. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
