Re: [PATCH 6/6] blk-mq: manage hctx map via xarray

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 02, 2022 at 05:53:44PM +0800, Ming Lei wrote:
> Another point is that 'unsigned long *' is passed to xa_find() as index.
> However, almost all users of queue_for_each_hw_ctx() defines hctx index
> as 'unsigned int'.
> 
> If we switch to xa_for_each(), the type of hctx index needs to be changed
> to 'unsigned long' for every queue_for_each_hw_ctx(). But xa_load()
> needn't such change.
> 
> Also from user viewpoint, looks 'unsigned long' change for hctx index is
> still a bit confusing, IMO.

If you use xarray you need to fit the convention it expects, that should
not be in any way a surprise.



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux