On Wed, Mar 02, 2022 at 10:06:04AM +0800, Ming Lei wrote: > I did considered xa_for_each(), but it requires rcu read lock. No, I doesn't. It just takes a RCU lock internally. > Also queue_for_each_hw_ctx() is supposed to not run in fast path, > meantime xa_load() is lightweight enough too, so repeated xa_load() > is fine here. I'd rather have the clarity of the proper iterators.