On 02/03/2022 09:22, Ming Lei wrote:
What is reverse firtree ordering here? I don't know what is wrong
with the above one line change from patch style viewpoint, and
checkpatch complains nothing here.
checkpath would not complain about this. I'm talking about:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/maintainer-tip.rst#n587
The original code had:
struct blk_mq_tags *tags;
int node;
as opposed to:
int node;
struct blk_mq_tags *tags;
That's all. The block code seems to mostly follow this style when possible.
It's just a style issue.
But my patch doesn't change the order,:-)
Right, and I am just saying that if you were to maintain this coding
style then it should. But, as I alluded before, for only 2 declarations
is not so important.
Thanks,
John
