On Wed, Feb 16, 2022 at 04:32:26PM +0100, Markus Blöchl wrote: > On Wed, Feb 16, 2022 at 04:09:01PM +0100, Christoph Hellwig wrote: > > For surprise removals that have already marked the disk dead, there is > > no point in calling fsync_bdev as all I/O will fail anyway, so skip it. > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > --- > > block/genhd.c | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/block/genhd.c b/block/genhd.c > > index 626c8406f21a6..f68bdfe4f883b 100644 > > --- a/block/genhd.c > > +++ b/block/genhd.c > > @@ -584,7 +584,14 @@ void del_gendisk(struct gendisk *disk) > > blk_drop_partitions(disk); > > blk_drop_partitions() also invokes fsync_bdev() via delete_partition(). > So why treat them differently? Yeah. I guess we should just skip this patch for now.
