On 01/03/2020 08:44 PM, Singh, Balbir wrote: >> >Since disk_set_capacity(() is on the same line as set_capacity() >> >we should follow the same convention, which is :- >> > >> >1. Avoid exporting symbol. >> >2. Mark new function in-line. >> > >> >Unless there is a very specific reason for breaking the pattern. >> > > I don't see the benefit of marking it as inline. I expect this code to be > potentially expanded to provide callbacks into file system code for expansion > (something you brought up), marking it as inline might be a limitation. > That can be done as a prep patch when framework is ready. > I'd rather not clutter the headers with this code, but I am open to what the > maintainers think as well. > Okay. > Balbir Singh. > >
