On Fri, 2020-01-03 at 06:16 +0000, Chaitanya Kulkarni wrote: > On 01/01/2020 11:53 PM, Balbir Singh wrote: > > Allow block/genhd to notify user space (via udev) about disk size changes > > using a new helper disk_set_capacity(), which is a wrapper on top > > of set_capacity(). disk_set_capacity() will only notify via udev if > > the current capacity or the target capacity is not zero. > > > > Suggested-by: Christoph Hellwig<hch@xxxxxx> > > Signed-off-by: Someswarudu Sangaraju<ssomesh@xxxxxxxxxx> > > Signed-off-by: Balbir Singh<sblbir@xxxxxxxxxx> > > --- > > Since disk_set_capacity(() is on the same line as set_capacity() > we should follow the same convention, which is :- > > 1. Avoid exporting symbol. > 2. Mark new function in-line. > > Unless there is a very specific reason for breaking the pattern. > I don't see the benefit of marking it as inline. I expect this code to be potentially expanded to provide callbacks into file system code for expansion (something you brought up), marking it as inline might be a limitation. I'd rather not clutter the headers with this code, but I am open to what the maintainers think as well. Balbir Singh.
