Re: [PATCH] block: remove unused mp_bvec_last_segment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 04, 2020 at 10:43:09AM -0700, Jens Axboe wrote:
> After commit 85a8ce62c2ea ("block: add bio_truncate to fix guard_bio_eod")
> this function is unused, remove it.
> 
> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
> 
> ---
> 
> diff --git a/include/linux/bvec.h b/include/linux/bvec.h
> index 679a42253170..a81c13ac1972 100644
> --- a/include/linux/bvec.h
> +++ b/include/linux/bvec.h
> @@ -153,26 +153,4 @@ static inline void bvec_advance(const struct bio_vec *bvec,
>  	}
>  }
>  
> -/*
> - * Get the last single-page segment from the multi-page bvec and store it
> - * in @seg
> - */
> -static inline void mp_bvec_last_segment(const struct bio_vec *bvec,
> -					struct bio_vec *seg)
> -{
> -	unsigned total = bvec->bv_offset + bvec->bv_len;
> -	unsigned last_page = (total - 1) / PAGE_SIZE;
> -
> -	seg->bv_page = bvec->bv_page + last_page;
> -
> -	/* the whole segment is inside the last page */
> -	if (bvec->bv_offset >= last_page * PAGE_SIZE) {
> -		seg->bv_offset = bvec->bv_offset % PAGE_SIZE;
> -		seg->bv_len = bvec->bv_len;
> -	} else {
> -		seg->bv_offset = 0;
> -		seg->bv_len = total - last_page * PAGE_SIZE;
> -	}
> -}
> -
>  #endif /* __LINUX_BVEC_ITER_H */
> 
> -- 
> Jens Axboe
> 

Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxx>

-- 
Ming




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux