On Thu, 2019-05-02 at 03:43 +-0000, Chaitanya Kulkarni wrote: +AD4 On 5/1/19 8:48 AM, Bart Van Assche wrote: +AD4 +AD4 On Tue, 2019-04-30 at 21:28 -0700, Chaitanya Kulkarni wrote: +AD4 +AD4 +AD4 -+ACM-define BLKTRACESETUP32 +AF8-IOWR(0x12, 115, struct compat+AF8-blk+AF8-user+AF8-trace+AF8-setup) +AD4 +AD4 +AD4 +- +AD4 +AD4 +AD4 +-/+ACo XXX: temp work around for RFC +ACo-/ +AD4 +AD4 +AD4 +-+ACM-define BLKTRACESETUP32 +AF8-IOWR(0x13, 115, struct compat+AF8-blk+AF8-user+AF8-trace+AF8-setup) +AD4 +AD4 +AD4 +AD4 This change breaks user space so this change is not acceptable. I think you +AD4 +AD4 want to introduce a new ioctl instead of modifying an existing ioctl. +AD4 +AD4 Additionally, have you considered to split the blktrace+AF8-api.h header file +AD4 +AD4 into two header files: one with kernel-internal definitions and a second one +AD4 +AD4 with definitions that are shared with user space (include/uapi/...)? +AD4 +AD4 I want to avoid modifying an existing IOCTL, I'll add a new ioctl and +AD4 update the tools to use the extension IOCTL and split the header file +AD4 also. Also I found that user space tools have replicated BLK+AF8-XX+AF8-XXX +AD4 definitions, will be okay to keep all those in one place and include +AD4 those from the appropriate header file ? Hi Chaitanya, I think all definitions that are relevant for the user space blktrace tool should be moved into a header file under include/uapi/linux. I'm not sure what the best strategy is to include that header file in the blktrace tool. Another project that interfaces with the kernel (rdma-core+ADs see also https://github.com/linux-rdma/rdma-core/) periodically copies kernel header files into its own source code repository. Bart.
