On Tue, 2019-04-30 at 21:28 -0700, Chaitanya Kulkarni wrote: +AD4 -+ACM-define BLKTRACESETUP32 +AF8-IOWR(0x12, 115, struct compat+AF8-blk+AF8-user+AF8-trace+AF8-setup) +AD4 +- +AD4 +-/+ACo XXX: temp work around for RFC +ACo-/ +AD4 +-+ACM-define BLKTRACESETUP32 +AF8-IOWR(0x13, 115, struct compat+AF8-blk+AF8-user+AF8-trace+AF8-setup) This change breaks user space so this change is not acceptable. I think you want to introduce a new ioctl instead of modifying an existing ioctl. Additionally, have you considered to split the blktrace+AF8-api.h header file into two header files: one with kernel-internal definitions and a second one with definitions that are shared with user space (include/uapi/...)? Thanks, Bart.
