Re: [PATCH] blk-mq: code clean-up by adding an API to clear set->mq_map

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2018-07-02 at 15:27 +0200, Johannes Thumshirn wrote:
> On Mon, Jul 02, 2018 at 10:20:03PM +0900, Minwoo Im wrote:
> [...]
> > 
> > > 
> > > You could still evaluate if it isn't worth to make it:
> > > +static void blk_mq_clear_mq_map(struct blk_mq_tag_set *set)
> > > +{
> > > +	int cpu;
> > > +
> > > +	for_each_possible_cpu(cpu)
> > > +		set->mq_map[cpu] = 0;
> > > +}
> > > 
> > > and put it into 'include/linux/blk-mq.h'.
> > Do you mean this whole bunch of function should be moved into blk-mq.h with
> > 'inline' format?
> yes

Johannes,

I was wondering you did mean 'inline' or not because the function in the
previous mail only with 'static' without 'inline' keyword :)
That's why I asked it one more time to figure out what you really mean.

I really appreciate your kindly directives.

I'll make it up for v2 patch.

Thanks, really.

	Minwoo Im



[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux