On Mon, Jul 02, 2018 at 09:55:57PM +0900, Minwoo Im wrote:
> No 2nd follow-up patch will be there. I thought these two parts are
> using a same unit-function to clear the set->mq-map. Also thought it
> would be great for the future use when it needs to be cleared.
> However, as you mentioned, I totally agree with your point. It seems
> just churns for churns' sake with no more usage for now.
I actually mis-read your patch, I'm sorry.
You're consolidating two callers of this so I guess this is not so
problematic. I somehow ignored the first hunk in the patch.
You could still evaluate if it isn't worth to make it:
+static void blk_mq_clear_mq_map(struct blk_mq_tag_set *set)
+{
+ int cpu;
+
+ for_each_possible_cpu(cpu)
+ set->mq_map[cpu] = 0;
+}
and put it into 'include/linux/blk-mq.h'.
Johannes
--
Johannes Thumshirn Storage
jthumshirn@xxxxxxx +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
