On Mon, Jul 02, 2018 at 05:54:22AM -0700, Christoph Hellwig wrote: > On Mon, Jul 02, 2018 at 01:06:42PM +0800, Ming Lei wrote: > > With the introduced module parameter of 'use_blk_mq', it is easy > > to switch between 'blk_mq' and 'non_blk_mq' by reloading scsi_debug > > module, so that we can test scsi_mq/blk_mq related regressions easily. > > No. We should not make a per driver choice. Btw, wouldn't it be time for: diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 35c909bbf8ba..bd115bab162e 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@ -49,6 +49,7 @@ config SCSI_NETLINK config SCSI_MQ_DEFAULT bool "SCSI: use blk-mq I/O path by default" + default y depends on SCSI ---help--- This option enables the new blk-mq based I/O path for SCSI again and see how we've improved in the last year and a half? Johannes -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850