Hi Johannes,
I appreciate your kindly response.
On Mon, 2018-07-02 at 15:02 +0200, Johannes Thumshirn wrote:
> On Mon, Jul 02, 2018 at 09:55:57PM +0900, Minwoo Im wrote:
> >
> > No 2nd follow-up patch will be there. I thought these two parts are
> > using a same unit-function to clear the set->mq-map. Also thought it
> > would be great for the future use when it needs to be cleared.
> > However, as you mentioned, I totally agree with your point. It seems
> > just churns for churns' sake with no more usage for now.
> I actually mis-read your patch, I'm sorry.
>
> You're consolidating two callers of this so I guess this is not so
> problematic. I somehow ignored the first hunk in the patch.
>
> You could still evaluate if it isn't worth to make it:
> +static void blk_mq_clear_mq_map(struct blk_mq_tag_set *set)
> +{
> + int cpu;
> +
> + for_each_possible_cpu(cpu)
> + set->mq_map[cpu] = 0;
> +}
>
> and put it into 'include/linux/blk-mq.h'.
Do you mean this whole bunch of function should be moved into blk-mq.h with
'inline' format?
I have already added this function prototype to blk-mq.h without 'static' to
make blk-mq-pci.c to use it.
If you don't mind, can you please elaborate a little bit more?
Thanks,
Minwoo Im
>
> Johannes
