On Wed, Nov 08, 2017 at 11:08:13AM -0700, Jens Axboe wrote: > On 11/08/2017 11:03 AM, Christoph Hellwig wrote: > > On Wed, Nov 08, 2017 at 08:36:25AM -0700, Jens Axboe wrote: > >> On 11/08/2017 08:34 AM, Christoph Hellwig wrote: > >>> On Wed, Nov 08, 2017 at 08:20:58AM -0700, Jens Axboe wrote: > >>>> On top of that, there are no users of it at all... > >>> > >>> But Mikulas wants to add one :) > >> > >> I know... > >> > >>> Note that __bio_kmap_atomic has the same issues, only has a single > >>> users either and would be cleaner if opencoded there as it already > >>> has the current bvec. See patch below. > >> > >> Kill them all with fire. The open coded version is much clearer. > > > > Feel free to throw the patch in under either your or my name. > > I'll do a combo. Just checking if it's OK I add your signed-off-by > to the patch, I don't want something with you as an author, but > not having an SOB. sure: Reviewed-by: Christoph Hellwig <hch@xxxxxx> for my incremental bio_kmap_atomic removal. But I can also just send a correct patch, give me a few minutes. > > -- > Jens Axboe > ---end quoted text---
