On 11/08/2017 08:34 AM, Christoph Hellwig wrote: > On Wed, Nov 08, 2017 at 08:20:58AM -0700, Jens Axboe wrote: >> On top of that, there are no users of it at all... > > But Mikulas wants to add one :) I know... > Note that __bio_kmap_atomic has the same issues, only has a single > users either and would be cleaner if opencoded there as it already > has the current bvec. See patch below. Kill them all with fire. The open coded version is much clearer. -- Jens Axboe