Re: [PATCHv3 4/7] block: Introduce a dedicated lock for protecting queue elevator updates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



There's weird upper case for the first character after block.  I know
some subsystems like this, but in general try to at least be consistent
for the series.

> +	/*
> +	 * attributes which require some form of locking
> +	 * other than q->sysfs_lock

Make that a proper sentence:

	 * Attributes which require some form of locking
	 * other than q->sysfs_lock.

> +	/*
> +	 * protects elevator switch/update
> +	 */

Also make this a full sentence, and mention which fields this protects.

Otherwise looks good.




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux