Re: [PATCHv3 2/7] block: move q->sysfs_lock and queue-freeze under show/store method

To: Nilay Shroff <nilay@xxxxxxxxxxxxx>
Subject: Re: [PATCHv3 2/7] block: move q->sysfs_lock and queue-freeze under show/store method
From: Christoph Hellwig <hch@xxxxxx>
Date: Mon, 24 Feb 2025 17:31:21 +0100
Cc: linux-block@xxxxxxxxxxxxxxx, hch@xxxxxx, ming.lei@xxxxxxxxxx, dlemoal@xxxxxxxxxx, hare@xxxxxxx, axboe@xxxxxxxxx, gjoyce@xxxxxxx
In-reply-to: <20250224133102.1240146-3-nilay@linux.ibm.com>
References: <20250224133102.1240146-1-nilay@linux.ibm.com> <20250224133102.1240146-3-nilay@linux.ibm.com>
User-agent: Mutt/1.5.17 (2007-11-01)

Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCHv3 0/7] block: fix lock order and remove redundant locking
  - From: Nilay Shroff
- [PATCHv3 2/7] block: move q->sysfs_lock and queue-freeze under show/store method
  - From: Nilay Shroff